linux-kernel - Re: [PATCH 09/19] lib: test_objpool: Use kthread_run_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa57bdec-0b29-4e6f-92c8-a223cdbd9ff0@bytedance.com>
Date: Wed, 14 Aug 2024 10:53:12 +0800
From: "wuqiang.matt" <wuqiang.matt@...edance.com>
To: Frederic Weisbecker <frederic@...nel.org>,
 LKML <linux-kernel@...r.kernel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 09/19] lib: test_objpool: Use kthread_run_on_cpu()

On 2024/8/8 00:02, Frederic Weisbecker wrote:
> Use the proper API instead of open coding it.
> 
> Signed-off-by: Frederic Weisbecker <frederic@...nel.org>
> ---
>   lib/test_objpool.c | 19 +++++--------------
>   1 file changed, 5 insertions(+), 14 deletions(-)
> 
> diff --git a/lib/test_objpool.c b/lib/test_objpool.c
> index bfdb81599832..2c09dd91e731 100644
> --- a/lib/test_objpool.c
> +++ b/lib/test_objpool.c
> @@ -371,14 +371,10 @@ static int ot_start_sync(struct ot_test *test)
>   		if (!cpu_online(cpu))
>   			continue;
>   
> -		work = kthread_create_on_node(ot_thread_worker, item,
> -				cpu_to_node(cpu), "ot_worker_%d", cpu);
> -		if (IS_ERR(work)) {
> +		work = kthread_run_on_cpu(ot_thread_worker, item,
> +					  cpu, "ot_worker_%d");
> +		if (IS_ERR(work))
>   			pr_err("failed to create thread for cpu %d\n", cpu);
> -		} else {
> -			kthread_bind(work, cpu);
> -			wake_up_process(work);
> -		}
>   	}
>   
>   	/* wait a while to make sure all threads waiting at start line */
> @@ -562,14 +558,9 @@ static int ot_start_async(struct ot_test *test)
>   		if (!cpu_online(cpu))
>   			continue;
>   
> -		work = kthread_create_on_node(ot_thread_worker, item,
> -				cpu_to_node(cpu), "ot_worker_%d", cpu);
> -		if (IS_ERR(work)) {
> +		work = kthread_run_on_cpu(ot_thread_worker, item, cpu, "ot_worker_%d");
> +		if (IS_ERR(work))
>   			pr_err("failed to create thread for cpu %d\n", cpu);
> -		} else {
> -			kthread_bind(work, cpu);
> -			wake_up_process(work);
> -		}
>   	}
>   
>   	/* wait a while to make sure all threads waiting at start line */

Looks good to me. Thanks for the simplification.

Reviewed-by: Matt Wu <wuqiang.matt@...edance.com>