linux-kernel - Re: [PATCH v2 2/2] perf sched timehist: Remove BUG_ON in timehist_sched_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80ededea-8fb2-49a7-8f63-13bd7812d1a1@linux.ibm.com>
Date: Thu, 15 Aug 2024 00:12:06 +0530
From: Madadi Vineeth Reddy <vineethr@...ux.ibm.com>
To: Yang Jihong <yangjihong@...edance.com>
Cc: namhyung@...nel.org, acme@...nel.org, peterz@...radead.org,
        mingo@...hat.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
        irogers@...gle.com, adrian.hunter@...el.com, kan.liang@...ux.intel.com,
        james.clark@....com, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Madadi Vineeth Reddy <vineethr@...ux.ibm.com>
Subject: Re: [PATCH v2 2/2] perf sched timehist: Remove BUG_ON in
 timehist_sched_change_event()

On 12/08/24 18:56, Yang Jihong wrote:
> The BUG_ON(thread__tid(thread) != 0) in timehist_sched_change_event()
> is redundant, remove it.
> No functional change.
> 
> Fixes: 07235f84ece6 ("perf sched timehist: Add -I/--idle-hist option")
> Signed-off-by: Yang Jihong <yangjihong@...edance.com>
> ---
>  tools/perf/builtin-sched.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 177634df1ba5..309dcfb3796d 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -2700,8 +2700,6 @@ static int timehist_sched_change_event(struct perf_tool *tool,
>  			struct idle_thread_runtime *itr = (void *)tr;
>  			struct thread_runtime *last_tr;
>  
> -			BUG_ON(thread__tid(thread) != 0);
> -
>  			if (itr->last_thread == NULL)
>  				goto out;
>  

Yes, that indeed is redundant.

Reviewed-by: Madadi Vineeth Reddy <vineethr@...ux.ibm.com>

Thanks and Regards
Madadi Vineeth Reddy