linux-kernel - Re: [PATCH 1/3] fault-inject: improve build for CONFIG_FAULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240814121220.adcbbc0db20c6821a05da11e@linux-foundation.org>
Date: Wed, 14 Aug 2024 12:12:20 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Jani Nikula <jani.nikula@...el.com>
Cc: linux-kernel@...r.kernel.org, intel-xe@...ts.freedesktop.org,
 linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 akinobu.mita@...il.com, lucas.demarchi@...el.com, rodrigo.vivi@...el.com,
 thomas.hellstrom@...ux.intel.com, robdclark@...il.com,
 quic_abhinavk@...cinc.com, dmitry.baryshkov@...aro.org
Subject: Re: [PATCH 1/3] fault-inject: improve build for
 CONFIG_FAULT_INJECTION=n

On Wed, 14 Aug 2024 09:57:31 +0300 Jani Nikula <jani.nikula@...el.com> wrote:

> > Removing a nested include exposes all those sites which were
> > erroneously depending upon that nested include.  Here's what I have
> > found so far, there will be more.
> 
> Right. I didn't hit them with the configs I tried... though I wonder why
> not, especially lib/fault-inject.c puzzles me.
> 
> How do you want to proceed? Arguably uncovering and fixing those places
> is good, but that's kind of an unintended consequence here.

Is OK, it's a good change.  I fixed everything which my usual build
testing covers.  Other things will be reported and I'll fix those also.
If you have time to eyeball the 36 files which include fault-inject.h
then that would help things along.