linux-kernel - Re: [PATCH net-next v2 1/2] net/smc: introduce statistics for allocated ringbufs of link group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b680756a-920d-419f-92ec-4be06aa3d8f5@linux.alibaba.com>
Date: Wed, 14 Aug 2024 11:10:33 +0800
From: Wen Gu <guwen@...ux.alibaba.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: wenjia@...ux.ibm.com, jaka@...ux.ibm.com, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, alibuda@...ux.alibaba.com,
 tonylu@...ux.alibaba.com, linux-kernel@...r.kernel.org,
 linux-s390@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net/smc: introduce statistics for
 allocated ringbufs of link group



On 2024/8/13 22:40, Jakub Kicinski wrote:
> On Tue, 13 Aug 2024 17:55:17 +0800 Wen Gu wrote:
>> On 2024/8/13 08:41, Jakub Kicinski wrote:
>>> On Wed,  7 Aug 2024 15:59:38 +0800 Wen Gu wrote:
>>>> +	if (nla_put_u64_64bit(skb, SMC_NLA_LGR_R_SNDBUF_ALLOC,
>>>> +			      lgr->alloc_sndbufs, SMC_NLA_LGR_R_PAD))
>>>
>>> nla_put_uint()
>>
>> Hi, Jakub. Thank you for reminder.
>>
>> I read the commit log and learned the advantages of this helper.
>> But it seems that the support for corresponding user-space helpers
>> hasn't kept up yet, e.g. can't find a helper like nla_get_uint in
>> latest libnl.
> 
> Add it, then.

OK. So I guess we should use nla_put_uint for all 64bit cases from now on?