linux-kernel - Re: [PATCH V2 02/10] accel/amdxdna: Support hardware mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9be9626b-009c-165e-f025-ee177d051d02@quicinc.com>
Date: Wed, 14 Aug 2024 16:02:42 -0600
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: Lizhi Hou <lizhi.hou@....com>, <ogabbay@...nel.org>,
        <dri-devel@...ts.freedesktop.org>
CC: <linux-kernel@...r.kernel.org>, <min.ma@....com>, <max.zhen@....com>,
        <sonal.santan@....com>, <king.tam@....com>,
        George Yang <George.Yang@....com>
Subject: Re: [PATCH V2 02/10] accel/amdxdna: Support hardware mailbox

On 8/14/2024 3:05 PM, Lizhi Hou wrote:
> 
> On 8/9/24 09:32, Jeffrey Hugo wrote:
>> On 8/5/2024 11:39 AM, Lizhi Hou wrote:
>>> +static int mailbox_acquire_msgid(struct mailbox_channel *mb_chann, 
>>> struct mailbox_msg *mb_msg)
>>> +{
>>> +    unsigned long flags;
>>> +    int msg_id;
>>> +
>>> +    spin_lock_irqsave(&mb_chann->chan_idr_lock, flags);
>>> +    msg_id = idr_alloc_cyclic(&mb_chann->chan_idr, mb_msg, 0,
>>> +                  MAX_MSG_ID_ENTRIES, GFP_NOWAIT);
>>> +    spin_unlock_irqrestore(&mb_chann->chan_idr_lock, flags);
>>
>> I think an xa struct would be preferred.
> 
> Can we defer this? This is in critical path.

Ok.  I would be satisfied with a high priority todo item for the conversion.

-Jeff