linux-kernel - RE: [PATCH net-next 1/4] dt-bindings: net: dsa: microchip: add SGMII port support to KSZ9477 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR11MB35667304A9B1D1899D788BC9EC872@MN2PR11MB3566.namprd11.prod.outlook.com>
Date: Wed, 14 Aug 2024 22:32:57 +0000
From: <Tristram.Ha@...rochip.com>
To: <krzk@...nel.org>, <krzk+dt@...nel.org>
CC: <davem@...emloft.net>, <conor+dt@...nel.org>, <edumazet@...gle.com>,
	<robh@...nel.org>, <olteanv@...il.com>, <f.fainelli@...il.com>,
	<andrew@...n.ch>, <devicetree@...r.kernel.org>,
	<UNGLinuxDriver@...rochip.com>, <Woojung.Huh@...rochip.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <marex@...x.de>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 1/4] dt-bindings: net: dsa: microchip: add SGMII
 port support to KSZ9477 switch

> On 14/08/2024 01:09, Tristram.Ha@...rochip.com wrote:
> >> On 10/08/2024 01:38, Tristram.Ha@...rochip.com wrote:
> >>> From: Tristram Ha <tristram.ha@...rochip.com>
> >>>
> >>> The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct
> >>> connect, 1 for 1000BaseT SFP, and 2 for 10/100/1000 SFP.
> >>
> >> Binding should say it, not commit msg. But aren't you duplicating
> >> something like phy-connection-type?
> >
> > The sgmii-mode parameter is just used internally.  I am not sure using
> 
> This does not matter.
> 
> > phy-connection-type or phy-mode is appropriate.
> 
> Depends on what this property expressed in terms of hardware. Looks like
> you want to say which SGMII mode is being used?

The driver can detect whether 10/100/1000Base-T copper SFP is being
used.  So the main purpose of this device tree parameter is to indicate
the SGMII module is directly connected to another one without using any
SFP.  This is a very rare case.  In such case the device tree parameter
can be changed to a flag to just indicate SFP is not used.