linux-kernel - Re: [PATCH 0/4] Omnivision OV4689 cropping and binning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8734n63dti.fsf@gmail.com>
Date: Thu, 15 Aug 2024 02:01:08 +0300
From: Mikhail Rudenko <mike.rudenko@...il.com>
To: Mikhail Rudenko <mike.rudenko@...il.com>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, Sakari Ailus
 <sakari.ailus@...ux.intel.com>, Laurent Pinchart
 <laurent.pinchart@...asonboard.com>, Jacopo Mondi <jacopo@...ndi.org>,
 Tommaso Merciai <tomm.merciai@...il.com>, Christophe JAILLET
 <christophe.jaillet@...adoo.fr>, Dave Stevenson
 <dave.stevenson@...pberrypi.com>, Mauro Carvalho Chehab
 <mchehab@...nel.org>
Subject: Re: [PATCH 0/4] Omnivision OV4689 cropping and binning

On 2024-06-16 at 23:24 +03, Mikhail Rudenko <mike.rudenko@...il.com> wrote:

> This small series consists of patches 17-20 from [1], which were
> requested to merged separately later. No significant changes have been
> made since and the R-b's are kept.
>
> Patch 1 implements configurable analogue crop rectangle via
> .set_selection callback. Patches 2 and 3 are refactorings and are not
> supposed to introduce any functional change. Patch 4 enables 2x2
> binning option.
>
> [1] https://lore.kernel.org/all/20240402164552.19171-1-mike.rudenko@gmail.com/
>
> Mikhail Rudenko (4):
>   media: i2c: ov4689: Configurable analogue crop
>   media: i2c: ov4689: Eliminate struct ov4689_mode
>   media: i2c: ov4689: Refactor ov4689_s_stream
>   media: i2c: ov4689: Implement 2x2 binning
>
>  drivers/media/i2c/ov4689.c | 483 +++++++++++++++++++++++++------------
>  1 file changed, 328 insertions(+), 155 deletions(-)

Gentle ping.

Sakari, in [1] you said the these four patches should be postponed until
internal API refactoring is complete. Is it complete now? Could you
point out the places where new API should be used?

[1] https://lore.kernel.org/all/ZhzEdXz-R2I6nZXf@kekkonen.localdomain/

--
Best regards,
Mikhail Rudenko