linux-kernel - Re: [PATCH v4 05/39] x86/resctrl: Use schema type to determine the schema format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90234a6d-d924-444c-b1c1-8cd90fd6c492@intel.com>
Date: Tue, 13 Aug 2024 20:57:58 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: James Morse <james.morse@....com>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>
CC: Fenghua Yu <fenghua.yu@...el.com>, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, H Peter Anvin
	<hpa@...or.com>, Babu Moger <Babu.Moger@....com>,
	<shameerali.kolothum.thodi@...wei.com>, D Scott Phillips OS
	<scott@...amperecomputing.com>, <carl@...amperecomputing.com>,
	<lcherian@...vell.com>, <bobo.shaobowang@...wei.com>,
	<tan.shaopeng@...itsu.com>, <baolin.wang@...ux.alibaba.com>, Jamie Iles
	<quic_jiles@...cinc.com>, Xin Hao <xhao@...ux.alibaba.com>,
	<peternewman@...gle.com>, <dfustini@...libre.com>, <amitsinght@...vell.com>,
	David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>, Dave
 Martin <dave.martin@....com>
Subject: Re: [PATCH v4 05/39] x86/resctrl: Use schema type to determine the
 schema format string



On 8/2/24 10:28 AM, James Morse wrote:
> @@ -255,6 +253,7 @@ struct rdt_resource *resctrl_arch_get_resource(enum resctrl_res_level l);
>    *			   user-space
>    * @list:	Member of resctrl_schema_all.
>    * @name:	The name to use in the "schemata" file.
> + * @fmt_str:	Format string to show domain value

nit: please follow style where all sentences in this portion end with a period/full-stop.

>    * @conf_type:	Whether this schema is specific to code/data.
>    * @res:	The resource structure exported by the architecture to describe
>    *		the hardware that is configured by this schema.
> @@ -265,6 +264,7 @@ struct rdt_resource *resctrl_arch_get_resource(enum resctrl_res_level l);
>   struct resctrl_schema {
>   	struct list_head		list;
>   	char				name[8];
> +	const char			*fmt_str;
>   	enum resctrl_conf_type		conf_type;
>   	struct rdt_resource		*res;
>   	u32				num_closid;