linux-kernel - Re: [linus:master] [mm] c0bff412e6: stress-ng.clone.ops_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGudoHECfSYd7EcxiY+soh157m9H4xfU1en=TgX_=QkpbsOFdg@mail.gmail.com>
Date: Wed, 14 Aug 2024 06:10:04 +0200
From: Mateusz Guzik <mjguzik@...il.com>
To: Yin Fengwei <fengwei.yin@...el.com>
Cc: David Hildenbrand <david@...hat.com>, kernel test robot <oliver.sang@...el.com>, 
	Peter Xu <peterx@...hat.com>, oe-lkp@...ts.linux.dev, lkp@...el.com, 
	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, 
	Huacai Chen <chenhuacai@...nel.org>, Jason Gunthorpe <jgg@...dia.com>, 
	Matthew Wilcox <willy@...radead.org>, Nathan Chancellor <nathan@...nel.org>, 
	Ryan Roberts <ryan.roberts@....com>, WANG Xuerui <kernel@...0n.name>, linux-mm@...ck.org, 
	ying.huang@...el.com, feng.tang@...el.com
Subject: Re: [linus:master] [mm] c0bff412e6: stress-ng.clone.ops_per_sec -2.9% regression

On Wed, Aug 14, 2024 at 5:02 AM Yin Fengwei <fengwei.yin@...el.com> wrote:
>
> On 8/13/24 03:14, Mateusz Guzik wrote:
> > would you mind benchmarking the change which merely force-inlines _compund_page?
> >
> > https://lore.kernel.org/linux-mm/66c4fcc5-47f6-438c-a73a-3af6e19c3200@redhat.com/
> This change can resolve the regression also:

Great, thanks.

David, I guess this means it would be fine to inline the entire thing
at least from this bench standpoint. Given that this is your idea I
guess you should do the needful(tm)? :)

> =========================================================================================
> tbox_group/testcase/rootfs/kconfig/compiler/nr_threads/testtime/test/cpufreq_governor/debug-setup:
>
> lkp-icl-2sp8/stress-ng/debian-12-x86_64-20240206.cgz/x86_64-rhel-8.3/gcc-12/100%/60s/clone/performance/yfw_test2
>
> commit:
>    9cb28da54643ad464c47585cd5866c30b0218e67  parent commit
>    c0bff412e67b781d761e330ff9578aa9ed2be79e  commit introduced regression
>    450b96d2c4f740152e03c6b79b484a10347b3ea9  the change proposed by David
>                                              in above link
>
> 9cb28da54643ad46 c0bff412e67b781d761e330ff95 450b96d2c4f740152e03c6b79b4
> ---------------- --------------------------- ---------------------------
>           %stddev     %change         %stddev     %change         %stddev
>               \          |                \          |                \
>        2906            +3.5%       3007            +0.4%       2919
>    stress-ng.clone.microsecs_per_clone
>      562884            -2.9%     546575            -0.6%     559718
>    stress-ng.clone.ops
>        9295            -2.9%       9028            -0.5%       9248
>    stress-ng.clone.ops_per_sec
>
>
>
> Regards
> Yin, Fengwei
>


-- 
Mateusz Guzik <mjguzik gmail.com>