linux-kernel - Re: [PATCH] speakup: i18n: modify incorrect comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240814055955.4mf5idugote3pihu@begin>
Date: Wed, 14 Aug 2024 07:59:55 +0200
From: Samuel Thibault <samuel.thibault@...-lyon.org>
To: bajing <bajing@...s.chinamobile.com>
Cc: w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
	speakup@...ux-speakup.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] speakup: i18n: modify incorrect comments

bajing, le mer. 14 août 2024 11:00:17 +0800, a ecrit:
> Regarding the text part, the comment was written incorrectly, so it needs to be modified.
> 
> Signed-off-by: bajing <bajing@...s.chinamobile.com>
> ---
>  drivers/accessibility/speakup/i18n.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/i18n.c b/drivers/accessibility/speakup/i18n.c
> index d62079b1661f..10c7cdc685f7 100644
> --- a/drivers/accessibility/speakup/i18n.c
> +++ b/drivers/accessibility/speakup/i18n.c
> @@ -541,7 +541,7 @@ static bool fmt_validate(char *template, char *user)
>   * If the function fails, then user_messages is untouched.
>   * Arguments:
>   * - index: a message number, as found in i18n.h.
> - * - text:  text of message.  Not NUL-terminated.
> + * - text:  text of message.  Not NULL-terminated.

? Man ascii says it's called NUL, not NULL. We don't want people to
confuse it with the NULL pointer anyway, so no, we don't to change this.

Samuel

>   * - length: number of bytes in text.
>   * Failure conditions:
>   * -EINVAL -  Invalid format specifiers in formatted message or illegal index.
> -- 
> 2.33.0