[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <003090ab-4ce2-4624-b5c5-33ceef521e9d@kernel.org>
Date: Wed, 14 Aug 2024 08:09:06 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jammy Huang <jammy_huang@...eedtech.com>, eajames@...ux.ibm.com,
mchehab@...nel.org, joel@....id.au, andrew@...id.au, pmenzel@...gen.mpg.de
Cc: linux-media@...r.kernel.org, openbmc@...ts.ozlabs.org,
linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] media: aspeed: Allow to capture from SoC display
(GFX)
On 14/08/2024 02:54, Jammy Huang wrote:
> +/*
> + * Get regmap without checking res, such as clk/reset, that could lead to
> + * conflict.
> + */
> +static struct regmap *aspeed_regmap_lookup(struct device_node *np, const char *property)
> +{
> + struct device_node *syscon_np __free(device_node) = of_parse_phandle(np, property, 0);
> + struct regmap *regmap;
Drop. The point of using __free was to make this very simple.
> +
> + if (!syscon_np)
> + return ERR_PTR(-ENODEV);
> +
> + regmap = device_node_to_regmap(syscon_np);
> +
> + return regmap;
> +}
> +
> static int aspeed_video_init(struct aspeed_video *video)
> {
> int irq;
> int rc;
> struct device *dev = video->dev;
>
> + video->scu = aspeed_regmap_lookup(dev->of_node, "aspeed,scu");
> + video->gfx = aspeed_regmap_lookup(dev->of_node, "aspeed,gfx");
Still undocumented. Respond to previous comment and confirm that you
understood it.
Best regards,
Krzysztof
Powered by blists - more mailing lists