linux-kernel - Re: [PATCH net-next 1/4] dt-bindings: net: dsa: microchip: add SGMII port support to KSZ9477 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <557edcbd-28ad-4e0e-a891-8bac8e2f3e53@kernel.org>
Date: Wed, 14 Aug 2024 08:12:50 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Tristram.Ha@...rochip.com, krzk+dt@...nel.org
Cc: davem@...emloft.net, conor+dt@...nel.org, edumazet@...gle.com,
 robh@...nel.org, olteanv@...il.com, f.fainelli@...il.com, andrew@...n.ch,
 devicetree@...r.kernel.org, UNGLinuxDriver@...rochip.com,
 Woojung.Huh@...rochip.com, kuba@...nel.org, pabeni@...hat.com,
 marex@...x.de, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: microchip: add SGMII
 port support to KSZ9477 switch

On 14/08/2024 01:09, Tristram.Ha@...rochip.com wrote:
>> On 10/08/2024 01:38, Tristram.Ha@...rochip.com wrote:
>>> From: Tristram Ha <tristram.ha@...rochip.com>
>>>
>>> The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct
>>> connect, 1 for 1000BaseT SFP, and 2 for 10/100/1000 SFP.
>>
>> Binding should say it, not commit msg. But aren't you duplicating
>> something like phy-connection-type?
> 
> The sgmii-mode parameter is just used internally.  I am not sure using

This does not matter.

> phy-connection-type or phy-mode is appropriate.

Depends on what this property expressed in terms of hardware. Looks like
you want to say which SGMII mode is being used?



Best regards,
Krzysztof