linux-kernel - Re: [PATCH 1/1] EDAC/igen6: Fix conversion of system address to physical memory address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024081442-pureness-salutary-35ec@gregkh>
Date: Wed, 14 Aug 2024 08:32:46 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
Cc: Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>,
	James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/1] EDAC/igen6: Fix conversion of system address to
 physical memory address

On Wed, Aug 14, 2024 at 02:10:11PM +0800, Qiuxu Zhuo wrote:
> The conversion of system address to physical memory address (as viewed by
> the memory controller) by igen6_edac is incorrect when the system address
> is above the TOM (Total amount Of populated physical Memory) for Elkhart
> Lake and Ice Lake (Neural Network Processor). Fix this conversion.
> 
> Fixes: 10590a9d4f23 ("EDAC/igen6: Add EDAC driver for Intel client SoCs using IBECC")
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
> ---
>  drivers/edac/igen6_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/igen6_edac.c b/drivers/edac/igen6_edac.c
> index 0fe75eed8973..189a2fc29e74 100644
> --- a/drivers/edac/igen6_edac.c
> +++ b/drivers/edac/igen6_edac.c
> @@ -316,7 +316,7 @@ static u64 ehl_err_addr_to_imc_addr(u64 eaddr, int mc)
>  	if (igen6_tom <= _4GB)
>  		return eaddr + igen6_tolud - _4GB;
>  
> -	if (eaddr < _4GB)
> +	if (eaddr >= igen6_tom)
>  		return eaddr + igen6_tolud - igen6_tom;
>  
>  	return eaddr;
> -- 
> 2.17.1
> 
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>