linux-kernel - Re: [PATCH v2 2/7] regulator: dt-bindings: microchip,mcp16502: Add voltage input supply documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ff0cad2-bbfc-4f8a-bdba-eda2db4fbca8@kernel.org>
Date: Wed, 14 Aug 2024 11:07:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andrei Simion <andrei.simion@...rochip.com>, claudiu.beznea@...on.dev,
 broonie@...nel.org, lgirdwood@...il.com, nicolas.ferre@...rochip.com,
 krzk+dt@...nel.org, conor+dt@...nel.org, robh@...nel.org,
 alexandre.belloni@...tlin.com
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/7] regulator: dt-bindings: microchip,mcp16502: Add
 voltage input supply documentation

On 12/08/2024 15:52, Andrei Simion wrote:
> Update the yaml schema with info about input supply phandle for
> each buck and ldo according with the PMIC MCP16502 Datasheet.
> 
> Signed-off-by: Andrei Simion <andrei.simion@...rochip.com>
> ---
> v1 -> v2:
> - added in v2
> ---
>  .../regulator/microchip,mcp16502.yaml         | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml b/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
> index 1aca3646789e..c3e1fc6e260e 100644
> --- a/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
> +++ b/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
> @@ -28,6 +28,21 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  lvin-supply:
> +    description: Input supply phandle for LDO1 and LDO2

If there is going to be respin, drop phandle. Stating obvious is not
helping - you describe here hardware, not DT.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof