lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4jkkom7ble6ireunal7jse63tifepwpwla2y4jpsqkx7mz466m@of74l7ksicon>
Date: Tue, 13 Aug 2024 21:31:01 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Wei Yang <richard.weiyang@...il.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        maple-tree@...ts.infradead.org
Subject: Re: [PATCH 1/2] maple_tree: fix comment typo of ma_root

* Wei Yang <richard.weiyang@...il.com> [240812 11:09]:
> In comment of mas_start(), we lists the return value for different
> cases. In case of a single entry, we set mas->status to ma_root, while
> the comment uses mas_root, which is not a maple_status.
> 
> Fix the typo according to the code.
> 
> Signed-off-by: Wei Yang <richard.weiyang@...il.com>

If you are fixing typos in a single comment, we can probably do that in
one patch.

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>

> ---
>  lib/maple_tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 3d2e207d9a5f..14ff54078f9e 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -1346,7 +1346,7 @@ static void mas_node_count(struct ma_state *mas, int count)
>   * Return:
>   * - If mas->node is an error or not mas_start, return NULL.
>   * - If it's an empty tree:     NULL & mas->status == ma_none
> - * - If it's a single entry:    The entry & mas->status == mas_root
> + * - If it's a single entry:    The entry & mas->status == ma_root
>   * - If it's a tree:            NULL & mas->status == safe root node.
>   */
>  static inline struct maple_enode *mas_start(struct ma_state *mas)
> -- 
> 2.34.1
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ