linux-kernel - Re: [PATCH v2] x86/ioremap: Use is_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qwzpfbi.ffs@tglx>
Date: Wed, 14 Aug 2024 12:30:09 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Christoph Hellwig <hch@...radead.org>, Max Ramanouski <max8rr8@...il.com>
Cc: x86@...nel.org, dave.hansen@...ux.intel.com, luto@...nel.org,
 peterz@...radead.org, linux-kernel@...r.kernel.org, jniethe@...dia.com,
 jhubbard@...dia.com, linux-mm@...ck.org
Subject: Re: [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap()

On Tue, Aug 13 2024 at 21:28, Christoph Hellwig wrote:
> Modulo the fixes discussion (and any commit log adjustments related to
> that), is_ioremap_addr is the right interface to check for an
> ioremap address.  So for the actual code change:

I'm not opposed to use is_ioremap_addr() as it restricts the check to
the actual ioremp region.

That said, I'm wondering why iounmap() silently bails out when invoked
with an address which is outside of the ioremap region. I'd say, any
invocation with an address outside of it, is broken, but I might be
missing something as always.

Thanks,

        tglx