linux-kernel - RE: [PATCH 2/2] usb: dwc3: xilinx: add missing depopulate in probe error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN0PR12MB59539C35E552516A6520121EB7872@MN0PR12MB5953.namprd12.prod.outlook.com>
Date: Wed, 14 Aug 2024 10:31:56 +0000
From: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Thinh Nguyen
	<Thinh.Nguyen@...opsys.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Simek, Michal" <michal.simek@....com>, Grygorii Strashko
	<grygorii.strashko@...com>, Vignesh R <vigneshr@...com>, Felipe Balbi
	<felipe.balbi@...ux.intel.com>, Piyush Mehta <piyush.mehta@....com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
CC: "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH 2/2] usb: dwc3: xilinx: add missing depopulate in probe
 error path

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, August 14, 2024 3:49 PM
> To: Thinh Nguyen <Thinh.Nguyen@...opsys.com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Simek, Michal <michal.simek@....com>;
> Grygorii Strashko <grygorii.strashko@...com>; Vignesh R <vigneshr@...com>;
> Felipe Balbi <felipe.balbi@...ux.intel.com>; Pandey, Radhey Shyam
> <radhey.shyam.pandey@....com>; Piyush Mehta
> <piyush.mehta@....com>; linux-usb@...r.kernel.org; linux-
> omap@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>;
> stable@...r.kernel.org
> Subject: [PATCH 2/2] usb: dwc3: xilinx: add missing depopulate in probe
> error path
> 
> Depopulate device in probe error paths to fix leak of children resources.
> 
> Fixes: 53b5ff83d893 ("usb: dwc3: xilinx: improve error handling for PM APIs")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Thanks!
> ---
>  drivers/usb/dwc3/dwc3-xilinx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
> index bb4d894c16e9..b7613a106da6 100644
> --- a/drivers/usb/dwc3/dwc3-xilinx.c
> +++ b/drivers/usb/dwc3/dwc3-xilinx.c
> @@ -330,6 +330,7 @@ static int dwc3_xlnx_probe(struct platform_device
> *pdev)
>  	return pm_runtime_resume_and_get(dev);
> 
>  err_pm_set_suspended:
> +	of_platform_depopulate(dev);
>  	pm_runtime_set_suspended(dev);
> 
>  err_clk_put:
> --
> 2.43.0