linux-kernel - RE: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AS8PR04MB86767916B0539B339120C2218C872@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date: Wed, 14 Aug 2024 01:49:30 +0000
From: Hongxing Zhu <hongxing.zhu@....com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: "shawnguo@...nel.org" <shawnguo@...nel.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>, "l.stach@...gutronix.de"
	<l.stach@...gutronix.de>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>
Subject: RE: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and
 "atu" for i.MX8M PCIe Endpoint

> -----Original Message-----
> From: Rob Herring (Arm) <robh@...nel.org>
> Sent: 2024年8月14日 0:33
> To: Hongxing Zhu <hongxing.zhu@....com>
> Cc: shawnguo@...nel.org; linux-pci@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> conor+dt@...nel.org; imx@...ts.linux.dev; linux-kernel@...r.kernel.org;
> kernel@...gutronix.de; l.stach@...gutronix.de; krzk+dt@...nel.org
> Subject: Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and
> "atu" for i.MX8M PCIe Endpoint
> 
> 
> On Tue, 13 Aug 2024 15:42:20 +0800, Richard Zhu wrote:
> > Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.
> >
> > For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
> > driver. This method is not good.
> >
> > In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
> > Frank suggests to fetch the dbi2 and atu from DT directly. This commit
> > is preparation to do that for i.MX8M PCIe EP.
> >
> > These changes wouldn't break driver function. When "dbi2" and "atu"
> > properties are present, i.MX PCIe driver would fetch the according
> > base addresses from DT directly. If only two reg properties are
> > provided, i.MX PCIe driver would fall back to the old method.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> > Reviewed-by: Frank Li <Frank.Li@....com>
> > ---
> >  .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml  | 13
> > +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> >
> 
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.
> 
> Missing tags:
> 
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
Hi Rob:
Oops, I'm really sorry about that I missing this reviewed-by tag in v5 by
 my mistake.
Thank you very much for your notice and kindly help.

Hi Shawn:
Can you help to pick-up Rob's reviewed-by tag?
Thanks in advanced.

Best Regards
Richard Zhu
> 
>