linux-kernel - RE: [PATCH v2 2/2] iio: imu: smi240: imu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AM8PR10MB47218D483B63C0CE88BD64FDCD872@AM8PR10MB4721.EURPRD10.PROD.OUTLOOK.COM>
Date: Wed, 14 Aug 2024 11:22:14 +0000
From: "Shen Jianping (ME-SE/EAD2)" <Jianping.Shen@...bosch.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "jic23@...nel.org"
	<jic23@...nel.org>, "lars@...afoo.de" <lars@...afoo.de>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "dima.fedrau@...il.com"
	<dima.fedrau@...il.com>, "marcelo.schmitt1@...il.com"
	<marcelo.schmitt1@...il.com>, "linux-iio@...r.kernel.org"
	<linux-iio@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Lorenz Christian (ME-SE/EAD2)"
	<Christian.Lorenz3@...bosch.com>, "Frauendorf Ulrike (ME/PJ-SW3)"
	<Ulrike.Frauendorf@...bosch.com>, "Dolde Kai (ME-SE/PAE-A3)"
	<Kai.Dolde@...bosch.com>
Subject: RE: [PATCH v2 2/2] iio: imu: smi240: imu driver

>
>On 13/08/2024 11:41, Shen Jianping (ME-SE/EAD2) wrote:
>>> +EXPORT_SYMBOL_GPL(smi240_core_probe);
>>> +
>>> +MODULE_AUTHOR("Markus Lochmann <markus.lochmann@...bosch.com>");
>>> +MODULE_AUTHOR("Stefan Gutmann <stefan.gutmann@...bosch.com>");
>>> +MODULE_DESCRIPTION("Bosch SMI240 driver"); MODULE_LICENSE("Dual
>>> +BSD/GPL");
>>
>> Hm? How many modules do you have here? What are their names?
>>
>> We have one module, named  "Bosch SMI240 driver". Any problem here?
>
>That's not the name of the module. That's description. What is the module filename
>(filename=name!)?
>
>Fix your quoting, because you misrepresent people's comments.

Sorry to give you this feeling, No, we we don't want to silence you to avoid work.  Just do not understand the module name correctly.

filename you mean the ko filename correct ?  We have only smi240.ko as output. Therefore just one module and we shall put MODULE_* only in one source file right. 
Shall we put in smi240_core.c or smi240_spi.c ?

Best regards,
Jianping Shen