linux-kernel - Re: [PATCH 02/19] mm: Drop is_huge_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240814123816.GC2032816@nvidia.com>
Date: Wed, 14 Aug 2024 09:38:16 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Peter Xu <peterx@...hat.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Sean Christopherson <seanjc@...gle.com>,
	Oscar Salvador <osalvador@...e.de>,
	Axel Rasmussen <axelrasmussen@...gle.com>,
	linux-arm-kernel@...ts.infradead.org, x86@...nel.org,
	Will Deacon <will@...nel.org>, Gavin Shan <gshan@...hat.com>,
	Paolo Bonzini <pbonzini@...hat.com>, Zi Yan <ziy@...dia.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Ingo Molnar <mingo@...hat.com>,
	Alistair Popple <apopple@...dia.com>,
	Borislav Petkov <bp@...en8.de>,
	David Hildenbrand <david@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>, kvm@...r.kernel.org,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	Yan Zhao <yan.y.zhao@...el.com>,
	Matthew Wilcox <willy@...radead.org>,
	"Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>
Subject: Re: [PATCH 02/19] mm: Drop is_huge_zero_pud()

On Fri, Aug 09, 2024 at 12:08:52PM -0400, Peter Xu wrote:
> It constantly returns false since 2017.  One assertion is added in 2019 but
> it should never have triggered, IOW it means what is checked should be
> asserted instead.
> 
> If it didn't exist for 7 years maybe it's good idea to remove it and only
> add it when it comes.
> 
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: Aneesh Kumar K.V <aneesh.kumar@...ux.ibm.com>
> Signed-off-by: Peter Xu <peterx@...hat.com>
> ---
>  include/linux/huge_mm.h | 10 ----------
>  mm/huge_memory.c        | 13 +------------
>  2 files changed, 1 insertion(+), 22 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason