linux-kernel - Re: [PATCH 4/5] ARM: dts: microchip: Rename the usb node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29e5fada-8f8a-4cc0-b1d0-14396f6736a6@kernel.org>
Date: Wed, 14 Aug 2024 15:22:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andrei Simion <andrei.simion@...rochip.com>, claudiu.beznea@...on.dev,
 nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, peda@...ntia.se
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, cristian.birsan@...rochip.com
Subject: Re: [PATCH 4/5] ARM: dts: microchip: Rename the usb node

On 14/08/2024 14:26, Andrei Simion wrote:
> Rename the usb node according to devicetree
> specification and update the label according
> with the node-specific standard as: ohci, ehci
> or gadget.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

...


> 
> diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts
> index 742fcf525e1b..52e166c8a365 100644
> --- a/arch/arm/boot/dts/microchip/aks-cdu.dts
> +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts
> @@ -50,13 +50,13 @@ macb0: ethernet@...c4000 {
>  				status = "okay";
>  			};
>  
> -			usb1: gadget@...a4000 {
> +			gadget: usb@...a4000 {
>  				atmel,vbus-gpio = <&pioC 15 GPIO_ACTIVE_HIGH>;
>  				status = "okay";
>  			};
>  		};
>  
> -		usb0: ohci@...000 {
> +		ohci: usb@...000 {

I don't think that these label renames are correct.

>  			num-ports = <2>;
>  			status = "okay";
>  		};
> diff --git a/arch/arm/boot/dts/microchip/animeo_ip.dts b/arch/arm/boot/dts/microchip/animeo_ip.dts
> index 29936bfbeeb7..911c8d9ee013 100644
> --- a/arch/arm/boot/dts/microchip/animeo_ip.dts
> +++ b/arch/arm/boot/dts/microchip/animeo_ip.dts
> @@ -136,7 +136,7 @@ ubi@...00 {
>  			};
>  		};
>  
> -		usb0: ohci@...000 {
> +		ohci: usb@...000 {
>  			num-ports = <2>;
>  			atmel,vbus-gpio = <&pioB 15 GPIO_ACTIVE_LOW>;
>  			status = "okay";
> diff --git a/arch/arm/boot/dts/microchip/at91-ariag25.dts b/arch/arm/boot/dts/microchip/at91-ariag25.dts
> index 713d18f80356..fedcf30a924e 100644
> --- a/arch/arm/boot/dts/microchip/at91-ariag25.dts
> +++ b/arch/arm/boot/dts/microchip/at91-ariag25.dts
> @@ -173,11 +173,11 @@ &usart3 {
>  	status = "okay";
>  };
>  
> -&usb0 {
> +&ohci {
>  	status = "okay";
>  	num-ports = <3>;
>  };
>  
> -&usb1 {
> +&ehci {
>  	status = "okay";
>  };

And how now the sorting works? I don't get the point of it. What is
exactly wrong in the label that justifies the code reshuffling.

BTW, is this some sort of v2? If so, provide changelog and properly
version your patches.

Best regards,
Krzysztof