linux-kernel - Re: [PATCH] i2c: Use IS_REACHABLE() for substituting empty ACPI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mslfjk3n.wl-tiwai@suse.de>
Date: Wed, 14 Aug 2024 15:43:24 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: <wsa+renesas@...g-engineering.com>,
	<tiwai@...e.com>,
	<linux-sound@...r.kernel.org>,
	<linux-i2c@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<patches@...nsource.cirrus.com>,
	"kernel test robot" <lkp@...el.com>
Subject: Re: [PATCH] i2c: Use IS_REACHABLE() for substituting empty ACPI functions

On Wed, 14 Aug 2024 14:16:49 +0200,
Richard Fitzgerald wrote:
> 
> Replace IS_ENABLED() with IS_REACHABLE() to substitute empty stubs for:
>     i2c_acpi_get_i2c_resource()
>     i2c_acpi_client_count()
>     i2c_acpi_find_bus_speed()
>     i2c_acpi_new_device_by_fwnode()
>     i2c_adapter *i2c_acpi_find_adapter_by_handle()
>     i2c_acpi_waive_d0_probe()
> 
> commit f17c06c6608a ("i2c: Fix conditional for substituting empty ACPI
> functions") partially fixed this conditional to depend on CONFIG_I2C,
> but used IS_ENABLED(), which is wrong since CONFIG_I2C is tristate.
> 
> CONFIG_ACPI is boolean but let's also change it to use IS_REACHABLE()
> to future-proof it against becoming tristate.
> 
> Somehow despite testing various combinations of CONFIG_I2C and CONFIG_ACPI
> we missed the combination CONFIG_I2C=m, CONFIG_ACPI=y.
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
> Fixes: f17c06c6608a ("i2c: Fix conditional for substituting empty ACPI functions")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202408141333.gYnaitcV-lkp@intel.com/

I suppose Wolfram will take this?

Reviewed-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi