[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <31635635-b743-446d-a94e-b3b8082c06a2@kernel.org>
Date: Wed, 14 Aug 2024 16:04:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kevin Chen <kevin_chen@...eedtech.com>, tglx@...utronix.de,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, joel@....id.au,
andrew@...econstruct.com.au, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: Add support for
ASPEED AST27XX INTC
On 14/08/2024 13:41, Kevin Chen wrote:
> The ASPEED AST27XX interrupt controller(INTC) contain second level and
> third level interrupt controller. The third level INTC combines 32 interrupt
> sources into 1 interrupt into parent interrupt controller. The second
> level INTC doing hand shake with third level INTC.
> +maintainers:
> + - Kevin Chen <kevin_chen@...eedtech.com>
> +
> +properties:
> + compatible:
> + enum:
> + - aspeed,ast2700-intc-ic
> +
> + reg:
> + minItems: 1
That's unconstrained. Instead: maxItems: 1
> +
> + interrupt-controller: true
> +
> + '#interrupt-cells':
> + const: 2
> +
> + interrupts:
> + minItems: 1
> + maxItems: 10
> + description:
> + It contains two types of interrupt controller. The first type is multiple
> + interrupt sources into parent interrupt controller. The second type is
> + 1 interrupt source to parent interrupt controller.
I think I asked already - list the items with description.
Why the number is flexible?
> +
> +required:
> + - compatible
> + - reg
> + - interrupt-controller
> + - '#interrupt-cells'
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + bus {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + interrupt-controller@...01b00 {
> + compatible = "aspeed,ast2700-intc-ic";
Messed indentation.
Best regards,
Krzysztof
Powered by blists - more mailing lists