linux-kernel - Re: [PATCH v2 6/6] arm64: dts: ti: k3-am65: Add ESM nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5c378e1-e503-43e6-a5ce-1fd53da19375@ti.com>
Date: Wed, 14 Aug 2024 09:05:34 -0500
From: Judith Mendez <jm@...com>
To: Nishanth Menon <nm@...com>, Jan Kiszka <jan.kiszka@...mens.com>,
        <devicetree@...r.kernel.org>
CC: Vignesh Raghavendra <vigneshr@...com>, <linux-kernel@...r.kernel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 6/6] arm64: dts: ti: k3-am65: Add ESM nodes

Hi all,

On 8/13/24 6:03 PM, Judith Mendez wrote:
> Add Error Signaling Module (ESM) instances in MCU and MAIN
> domains, set ESM interrupt sources for rti as per TRM [0] 9.4
> Interrupt Sources.
> 
> Add comments to describe what interrupt sources are routed to
> ESM modules.
> 
> [0] https://www.ti.com/lit/ug/spruid7e/spruid7e.pdf
> 
> Signed-off-by: Judith Mendez <jm@...com>
> ---
> Changes since v1:
> - Add patch 6/6 for am65x
> ---
>   arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 8 ++++++++
>   arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi  | 8 ++++++++
>   2 files changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 1af3dedde1f67..07c9f043dac0b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -54,6 +54,14 @@ gic_its: msi-controller@...0000 {
>   		};
>   	};
>   
> +	main_esm: esm@...000 {
> +		compatible = "ti,j721e-esm";
> +		reg = <0x00 0x700000 0x00 0x1000>;
> +		/* Interrupt sources: rti0, rti1, rti2, rti3 */
> +		ti,esm-pins = <224>, <225>, <226>, <227>;

I am not sure if someone knows the answer to this question, but..

I noticed that for rti, the interrupt source id's are different
for SR1 vs SR2, so which should be used here in k3-am65-main?

Here, I assumed SR2.

~ Judith


> +		bootph-pre-ram;
> +	};
> +
>   	serdes0: serdes@...000 {
>   		compatible = "ti,phy-am654-serdes";
>   		reg = <0x0 0x900000 0x0 0x2000>;
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> index 43c6118d2bf0f..e10cb9f483698 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> @@ -440,6 +440,14 @@ mcu_r5fss0_core1: r5f@...00000 {
>   		};
>   	};
>   
> +	mcu_esm: esm@...00000 {
> +		compatible = "ti,j721e-esm";
> +		reg = <0x00 0x40800000 0x00 0x1000>;
> +		/* Interrupt sources: mrti0, mrti1 */
> +		ti,esm-pins = <104>, <105>;
> +		bootph-pre-ram;
> +	};
> +
>   	mcu_rti1: watchdog@...10000 {
>   		compatible = "ti,j7-rti-wdt";
>   		reg = <0x0 0x40610000 0x0 0x100>;