linux-kernel - Re: [PATCH AUTOSEL 6.9 17/40] ASoC: topology: Fix route memory corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ea93e69-80da-4dc3-b63c-217b1f9f0447@linux.intel.com>
Date: Wed, 14 Aug 2024 16:07:55 +0200
From: Amadeusz Sławiński
 <amadeuszx.slawinski@...ux.intel.com>
To: Mark Brown <broonie@...nel.org>, Vitaly Chikunov <vt@...linux.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org,
 Thorsten Leemhuis <regressions@...mhuis.info>,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
 Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
 Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
 lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
 linux-sound@...r.kernel.org,
 Linux kernel regressions list <regressions@...ts.linux.dev>
Subject: Re: [PATCH AUTOSEL 6.9 17/40] ASoC: topology: Fix route memory
 corruption

On 8/14/2024 12:33 PM, Mark Brown wrote:
> On Wed, Aug 14, 2024 at 03:00:53AM +0300, Vitaly Chikunov wrote:
>> On Tue, Aug 13, 2024 at 04:42:04PM +0200, Amadeusz Sławiński wrote:
> 
>>> Should this be cherry-pick of both (they should apply cleanly):
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/sound/soc/soc-topology.c?id=e0e7bc2cbee93778c4ad7d9a792d425ffb5af6f7
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/sound/soc/soc-topology.c?id=0298f51652be47b79780833e0b63194e1231fa34
>>> or just the second one adjusted to apply for stable trees?
> 
>> I think having commit with memory corruption fix is more important to
>> stable kernels than not having the code cleanup commit. So, I would
>> suggest stable policy to be changed a bit, and minor commits like this
>> code cleanup, be allowed in stable if they are dependence of bug fixing
>> commits.
> 
>> Additionally, these neutral commits just make stable trees become closer
>> to mainline trees (which allows more bug fix commits to be applied
>> cleanly).
> 
> The reason I nacked the cleanup commit was just that there was no
> indication that it was a dependency or anything, it just looked like
> standard stuff with not reviewing bot output.

I've send both patches for stable in 
https://lore.kernel.org/linux-sound/20240814140657.2369433-1-amadeuszx.slawinski@linux.intel.com/T/#t