linux-kernel - Re: [PATCH] wifi: mwifiex: Fix uninitialized variable in mwifiex_cfg80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zr47j60F2NjclfcE@google.com>
Date: Thu, 15 Aug 2024 10:31:59 -0700
From: Brian Norris <briannorris@...omium.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: David Lin <yu-hao.lin@....com>,
	Francesco Dolcini <francesco@...cini.it>,
	Kalle Valo <kvalo@...nel.org>,
	Johannes Berg <johannes.berg@...el.com>,
	Aloka Dixit <quic_alokad@...cinc.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Rafael Beims <rafael.beims@...adex.com>,
	Ruan Jinjie <ruanjinjie@...wei.com>, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] wifi: mwifiex: Fix uninitialized variable in
 mwifiex_cfg80211_authenticate()

On Thu, Aug 15, 2024 at 02:29:27PM +0300, Dan Carpenter wrote:
> Smatch complains that:
> 
>     drivers/net/wireless/marvell/mwifiex/cfg80211.c:4408 mwifiex_cfg80211_authenticate()
>     error: uninitialized symbol 'varptr'.
> 
> It's a check for NULL, but "varptr" is either non-NULL or uninitialized.
> Initialize it to NULL.
> 
> Fixes: 36995892c271 ("wifi: mwifiex: add host mlme for client mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Acked-by: Brian Norris <briannorris@...omium.org>