linux-kernel - Re: [PATCH v2 1/3] iommufd: Reorder include files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zr5E9jlQ0HJt0BGE@Asurada-Nvidia>
Date: Thu, 15 Aug 2024 11:12:06 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Jason Gunthorpe <jgg@...dia.com>
CC: <kevin.tian@...el.com>, <robin.murphy@....com>, <joro@...tes.org>,
	<will@...nel.org>, <shuah@...nel.org>, <iommu@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] iommufd: Reorder include files

On Thu, Aug 15, 2024 at 02:51:40PM -0300, Jason Gunthorpe wrote:
> On Fri, Aug 02, 2024 at 05:32:02PM -0700, Nicolin Chen wrote:
> > Reorder include files to alphabetic order to simplify maintenance, and
> > separate local headers and global headers with a blank line.
> > 
> > No functional change intended.
> > 
> > Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> > ---
> >  drivers/iommu/iommufd/device.c          |  4 ++--
> >  drivers/iommu/iommufd/fault.c           |  4 ++--
> >  drivers/iommu/iommufd/io_pagetable.c    |  8 ++++----
> >  drivers/iommu/iommufd/io_pagetable.h    |  2 +-
> >  drivers/iommu/iommufd/ioas.c            |  2 +-
> >  drivers/iommu/iommufd/iommufd_private.h |  9 +++++----
> >  drivers/iommu/iommufd/iommufd_test.h    |  2 +-
> >  drivers/iommu/iommufd/iova_bitmap.c     |  2 +-
> >  drivers/iommu/iommufd/main.c            |  8 ++++----
> >  drivers/iommu/iommufd/pages.c           | 10 +++++-----
> >  drivers/iommu/iommufd/selftest.c        |  8 ++++----
> >  include/linux/iommufd.h                 |  4 ++--
> >  include/uapi/linux/iommufd.h            |  2 +-
> >  13 files changed, 33 insertions(+), 32 deletions(-)
> 
> I picked this on up to iommufd for-next

Thanks! Was hoping for that.

> When you get an answer if we can do something else for the MSI lets
> reconsider that patch, also the 3rd one has a kbuild failure.

Yea, let's hold the other patches in this series. I will submit
another selftest patch, after we have an alternative solution.

Nicolin