linux-kernel - Re: [PATCH v3 0/6] Add initial DTS for Samsung Galaxy Book4 Edge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172374583455.2827038.7584455596512370219.robh@kernel.org>
Date: Thu, 15 Aug 2024 12:28:18 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Marcus Glocker <marcus@...gul.ch>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
 Johan Hovold <johan@...nel.org>, linux-arm-msm@...r.kernel.org, 
 Marijn Suijten <marijn.suijten@...ainline.org>, 
 Conor Dooley <conor+dt@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
 Abel Vesa <abel.vesa@...aro.org>, Bjorn Andersson <andersson@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH v3 0/6] Add initial DTS for Samsung Galaxy Book4 Edge


On Thu, 15 Aug 2024 12:36:40 +0200, Marcus Glocker wrote:
> This DTS adds initial support for the Samsung Galaxy Book4 Edge laptop.
> Keyboard, Touch-pad, and UFS are working.  The Touch-screen needs further
> investigation, and is therefore disabled for now.
> 
> Changed from v2:
> - Squash Makefile patch to new DTS file patch.
> 
> Changed from v1:
> - Provide the patch in the expected format.
> - Added missing bindings.
> - Removed sound node.
> - Changed regulator syntax to be consistent.
> - Changed touchscreen node comment, and removed false pin definition.
> - Rename ufshc@ to ufs@.
> 
> Marcus Glocker (6):
>   dt-bindings: crypto: Add X1E80100 Crypto Engine
>   dt-bindings: phy: Add X1E80100 UFS
>   dt-bindings: ufs: Add X1E80100 UFS
>   arm64: dts: qcom: Add UFS node
>   dt-bindings: arm: Add Samsung Galaxy Book4 Edge
>   arm64: dts: qcom: Add Samsung Galaxy Book4 Edge DTS
> 
>  .../devicetree/bindings/arm/qcom.yaml         |   1 +
>  .../crypto/qcom,inline-crypto-engine.yaml     |   1 +
>  .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml        |   2 +
>  .../devicetree/bindings/ufs/qcom,ufs.yaml     |   2 +
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  .../x1e80100-samsung-galaxy-book4-edge.dts    | 959 ++++++++++++++++++
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi        |  71 ++
>  7 files changed, 1037 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-samsung-galaxy-book4-edge.dts
> 
> --
> 2.39.2
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/x1e80100-samsung-galaxy-book4-edge.dtb' for v2iah5yrne4u6uzrnzg36tvtxzqrpiez6io2gyyfrht2x42umw@...bqndiavxv:

arch/arm64/boot/dts/qcom/x1e80100-samsung-galaxy-book4-edge.dtb: domain-idle-states: cluster-sleep-0: 'idle-state-name' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/power/domain-idle-state.yaml#
arch/arm64/boot/dts/qcom/x1e80100-samsung-galaxy-book4-edge.dtb: domain-idle-states: cluster-sleep-1: 'idle-state-name' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/power/domain-idle-state.yaml#
arch/arm64/boot/dts/qcom/x1e80100-samsung-galaxy-book4-edge.dtb: phy@...7000: clocks: [[2, 0], [52, 242]] is too short
	from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-ufs-phy.yaml#
arch/arm64/boot/dts/qcom/x1e80100-samsung-galaxy-book4-edge.dtb: phy@...7000: 'vdda-phy-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-ufs-phy.yaml#
arch/arm64/boot/dts/qcom/x1e80100-samsung-galaxy-book4-edge.dtb: usb@...8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#