linux-kernel - Re: [PATCH] staging: drivers: scsi: lpfc: Fix warning: Using plain integer as NULL pointer in lpfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEKBCKNqGpC0hfEa4bzbEau4Mnwvasi6nqwa2HB+hMS2T2EtqA@mail.gmail.com>
Date: Fri, 16 Aug 2024 00:47:48 +0545
From: Dipendra Khadka <kdipendra88@...il.com>
To: Justin Tee <justintee8345@...il.com>
Cc: Justin Tee <justin.tee@...adcom.com>, james.smart@...adcom.com, 
	dick.kennedy@...adcom.com, martin.petersen@...cle.com, 
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: drivers: scsi: lpfc: Fix warning: Using plain
 integer as NULL pointer in lpfc_init.c

Hi Justin,

On Mon, 12 Aug 2024 at 22:09, Justin Tee <justintee8345@...il.com> wrote:
>
> Hi Dipendra,
>
> Perhaps the branch being referred to is out of date?
>

Sorry, you are right. It is due to the branch mismatching.

> This has already been addressed in the following commit.
>
> commit 5860d9fb5622ecd79913ac981403c612f6c8a2d8
> Author: Colin Ian King <colin.i.king@...il.com>
> Date:   Sat Sep 25 23:41:13 2021 +0100
>
>     scsi: lpfc: Return NULL rather than a plain 0 integer
>
>     Function lpfc_sli4_perform_vport_cvl() returns a pointer to struct
>     lpfc_nodelist so returning a plain 0 integer isn't good practice.  Fix this
>     by returning a NULL instead.
>
>     Link: https://lore.kernel.org/r/20210925224113.183040-1-colin.king@canonical.com
>     Signed-off-by: Colin Ian King <colin.king@...onical.com>
>     Signed-off-by: Martin K. Petersen martin.petersen@...cle.com
>
>
> And, the routine called lpfc_enable_node doesn’t exist anymore.
>
> Regards,
> Justin Tee

Best Regard,
Dipendra Khadka