linux-kernel - Re: [PATCH v2 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zr5RwL5qRVBKbHcc@lizhi-Precision-Tower-5810>
Date: Thu, 15 Aug 2024 15:06:40 -0400
From: Frank Li <Frank.li@....com>
To: Marek Vasut <marex@...x.de>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Mark Hasemeyer <markhas@...omium.org>,
	Alexander Stein <alexander.stein@...tq-group.com>,
	"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." <linux-input@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH v2 1/1] dt-bindings: input: touchscreen: convert
 ads7846.txt to yaml

On Thu, Aug 15, 2024 at 08:44:56PM +0200, Marek Vasut wrote:
> On 8/15/24 6:14 PM, Frank Li wrote:
>
> [...]
>
> > +  ti,debounce-max:
> > +    deprecated: true
> > +    $ref: /schemas/types.yaml#/definitions/uint16
> > +    description: Max number of additional readings per sample (u16).
>
> Could you drop the (u16) which is already part of the $ref'd type ?

Sorry, I forget it.

>
> [...]
>
> > +  ti,x-max:
> > +    deprecated: true
> > +    $ref: /schemas/types.yaml#/definitions/uint16
> > +    description: Maximum value on the X axis (u16).
> > +
> > +  ti,x-min:
>
> Is this deprecated too, the same way as x-max above is deprecated ?

I am not sure. I guest x-min and y-min is still useful becasue it may
indicate invalidated touch. but x-max and y-max should not usefull because
max value should be Vcc.  x-min and y-min help filter out some noise.

Frank

>
> > +    $ref: /schemas/types.yaml#/definitions/uint16
> > +    description: Minimum value on the X axis (u16).
>
> [...]