linux-kernel - Re: [PATCH 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zr1hZbAq/jrwyNQq@lizhi-Precision-Tower-5810>
Date: Wed, 14 Aug 2024 22:01:09 -0400
From: Frank Li <Frank.li@....com>
To: Rob Herring <robh@...nel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Marek Vasut <marex@...x.de>,
	Alexander Stein <alexander.stein@...tq-group.com>,
	"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." <linux-input@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: input: touchscreen: convert ads7846.txt
 to yaml

On Wed, Aug 14, 2024 at 03:49:02PM -0600, Rob Herring wrote:
> On Wed, Aug 14, 2024 at 03:13:45PM -0600, Rob Herring wrote:
> > On Wed, Aug 14, 2024 at 02:51:35PM -0400, Frank Li wrote:
> > > Convert binding doc ads7846.txt to yaml format.
> > > Additional change:
> > > - add ref to touchscreen.yaml and spi-peripheral-props.yaml.
> > > - use common node name touchscreen.
> > >
> > > Fix below warning: arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb: touchscreen@0:
> > > 	ti,x-min: b'\x00}' is not of type 'object', 'array', 'boolean', 'null'
> > >
> > > Signed-off-by: Frank Li <Frank.Li@....com>
> > > ---
> > > There are warning:
> > > Documentation/devicetree/bindings/input/touchscreen/ti,ads7843.yaml: properties:ti,x-plate-ohms: '$ref' should not be valid under {'const': '$ref'}
> > > 	hint: Standard unit suffix properties don't need a type $ref
> > >
> > > I don't know how to fix it. ti,x-plate-ohms is 16bit, but default it is
> > > uint32
> >
> > It's going to have to be a special case in dtschema. I'll work on a fix.
>
> Should be fixed now in dtschema main branch.

Strange, dt_binding_check can pass. but

 make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y imx8mm-var-som-symphony.dtb
  UPD     include/config/kernel.release
  DTC [C] arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb: touchscreen@0: ti,x-plate-ohms: 180 is not of type 'array'
	from schema $id: http://devicetree.org/schemas/property-units.yaml#

anything wrong?

Frank

>
> Rob