linux-kernel - Re: [PATCH v2] firmware: qcom_scm: Mark get_wq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172375444792.1011236.7773567649654210206.b4-ty@kernel.org>
Date: Thu, 15 Aug 2024 15:40:45 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Sibi Sankar <quic_sibis@...cinc.com>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Unnathi Chalicheemala <quic_uchalich@...cinc.com>
Cc: Murali Nalajala <quic_mnalajal@...cinc.com>,
	linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	kernel@...cinc.com,
	stable@...r.kernel.org,
	Elliot Berman <quic_eberman@...cinc.com>
Subject: Re: [PATCH v2] firmware: qcom_scm: Mark get_wq_ctx() as atomic call


On Wed, 14 Aug 2024 15:32:44 -0700, Unnathi Chalicheemala wrote:
> Currently get_wq_ctx() is wrongly configured as a standard call. When two
> SMC calls are in sleep and one SMC wakes up, it calls get_wq_ctx() to
> resume the corresponding sleeping thread. But if get_wq_ctx() is
> interrupted, goes to sleep and another SMC call is waiting to be allocated
> a waitq context, it leads to a deadlock.
> 
> To avoid this get_wq_ctx() must be an atomic call and can't be a standard
> SMC call. Hence mark get_wq_ctx() as a fast call.
> 
> [...]

Applied, thanks!

[1/1] firmware: qcom_scm: Mark get_wq_ctx() as atomic call
      commit: 9960085a3a82c58d3323c1c20b991db6045063b0

Best regards,
-- 
Bjorn Andersson <andersson@...nel.org>