linux-kernel - Re: [PATCH] tools build: Provide consistent build options for fixdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zr5uLlWGUEMYaroE@x1>
Date: Thu, 15 Aug 2024 18:07:58 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Thorsten Leemhuis <linux@...mhuis.info>
Cc: Alexander Gordeev <agordeev@...ux.ibm.com>,
	Brian Norris <briannorris@...omium.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kbuild@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH] tools build: Provide consistent build options for fixdep

On Thu, Aug 15, 2024 at 09:03:58AM +0200, Thorsten Leemhuis wrote:
> On 14.08.24 19:53, Alexander Gordeev wrote:
> > On Wed, Aug 14, 2024 at 10:35:00AM -0700, Brian Norris wrote:
> >
> >> FWIW, I already fielded some reports about this, and proposed a very
> >> similar (but not identical) fix:
> >>
> >> https://lore.kernel.org/lkml/20240814030436.2022155-1-briannorris@chromium.org/
> >>
> >> Frankly, I wasn't sure about HOSTxxFLAGS vs KBUILD_HOSTxxFLAGS -- and
> >> that's the difference between yours and mine. If yours works, that
> >> looks like the cleaner solution. So:
> >>
> >> Reviewed-by: Brian Norris <briannorris@...omium.org>
> >>
> >> Either way, it might be good to also include some of these tags if
> >> this is committed:
> >>
> >> Closes: https://lore.kernel.org/lkml/99ae0d34-ed76-4ca0-a9fd-c337da33c9f9@leemhuis.info/
> >> Fixes: ea974028a049 ("tools build: Avoid circular .fixdep-in.o.cmd issues")
> > 
> > Ah, I missed the issue was reported already - I would include these tags otherwise.
> > 
> > @Thorsten, would it be possible to test this fix?
> 
> Yeah, np. This one works as well, so feel free to add:
> 
> Tested-by: Thorsten Leemhuis <linux@...mhuis.info>

Thanks everybody, applied to perf-tools-next,

- Arnaldo