linux-kernel - lm8323/lm8333 keyboard drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zr6I9RB5mibU_12N@google.com>
Date: Thu, 15 Aug 2024 16:02:13 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: linux-input@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Trilok Soni <quic_tsoni@...cinc.com>,
	Felipe Balbi <balbi@...nel.org>, Tony Lindgren <tony@...mide.com>,
	Arnd Bergmann <arnd@...db.de>, wsa@...nel.org
Subject: lm8323/lm8333 keyboard drivers - drop or keep?

Hi,

LM8323 and LM8333 keyboard drivers do not appear to be used anywhere,
they only support configuration via platform data and refuse to work
without it, and nothing in the mainline sets up said platform data.

LM8323 I think was used in Nokia N810, but despite presence of
arch/arm/boot/dts/omap2420-n810.dts the device is not mentioned there
and the driver has not been updated to support device tree.

Additionally LM8323 seems to be pretty broken as far as PWM/LED handling
is concerned (taking mutexes in set_brightness() which should not be
sleeping) which suggests that nobody ever used it (or at least not used
the version that is in mainline).

Should either of these drivers be dropped? Or if it should be kept -
why?

Thanks.

-- 
Dmitry