linux-kernel - Re: [PATCH v4 1/2] x86: Add basic support for the Congatec CGEB BIOS interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zr2LGxZnU0nh2G0a@infradead.org>
Date: Wed, 14 Aug 2024 21:59:07 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Mary Strodl <mstrodl@....rit.edu>
Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	urezki@...il.com, hch@...radead.org, linux-mm@...ck.org,
	lee@...nel.org, andi.shyti@...nel.org, linux-i2c@...r.kernel.org,
	s.hauer@...gutronix.de, christian.gmeiner@...il.com,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org
Subject: Re: [PATCH v4 1/2] x86: Add basic support for the Congatec CGEB BIOS
 interface

On Wed, Aug 14, 2024 at 02:47:30PM -0400, Mary Strodl wrote:
> The Congatec CGEB is a BIOS interface found on some Congatec x86
> modules. It provides access to on board peripherals like I2C busses
> and watchdogs. This driver contains the basic support for accessing
> the CGEB interface and registers the child devices.

A very short description for very unusual code that copies exectutable
code from the the BIOS.  You'd really want to extend on all that here
in detail and explain how it is supposed to work and is safe.