[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b31f175e-4171-491f-9203-8186a84ab712@nexus-software.ie>
Date: Thu, 15 Aug 2024 01:16:28 +0100
From: Bryan O'Donoghue <pure.logic@...us-software.ie>
To: Depeng Shao <quic_depengs@...cinc.com>, rfoss@...nel.org,
todor.too@...il.com, bryan.odonoghue@...aro.org, mchehab@...nel.org,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-media@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel@...cinc.com, Yongsheng Li <quic_yon@...cinc.com>
Subject: Re: [PATCH 13/13] media: qcom: camss: Add support for VFE hardware
version Titan 780
On 12/08/2024 15:41, Depeng Shao wrote:
> +static void vfe_reg_update(struct vfe_device *vfe, enum vfe_line_id line_id)
> +{
> + int port_id = line_id;
> +
> + /* RUP(register update) registers has beem moved to CSID in Titan 780.
> + * Notify the event of trigger RUP.
> + */
> + camss_reg_update(vfe->camss, vfe->id, port_id, false);
> +}
> +
> +static inline void vfe_reg_update_clear(struct vfe_device *vfe,
> + enum vfe_line_id line_id)
> +{
> + int port_id = line_id;
> +
> + /* RUP(register update) registers has beem moved to CSID in Titan 780.
> + * Notify the event of trigger RUP clear.
> + */
> + camss_reg_update(vfe->camss, vfe->id, port_id, true);
> +}
Hmm, so another thought here.
camss_reg_update() is not an accurate name -> camss_rup_update() because
in this case we only update the RUP register, not the AUP or MUP.
reg is an abbreviation for register - but RUP has a defined meaning in
the camera namespace i.e. RUP = register update and its job is to latch
shadow registers to real registers.
camss_rup_update() please.
---
bod
Powered by blists - more mailing lists