| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3351b0db-4764-48a4-8bab-478ba7bfa4f4@gmail.com> Date: Thu, 15 Aug 2024 14:32:01 +0800 From: Alex Shi <seakeel@...il.com> To: LEROY Christophe <christophe.leroy2@...soprasteria.com>, "alexs@...nel.org" <alexs@...nel.org>, Will Deacon <will@...nel.org>, "Aneesh Kumar K . V" <aneesh.kumar@...nel.org>, Nick Piggin <npiggin@...il.com>, Peter Zijlstra <peterz@...radead.org>, Russell King <linux@...linux.org.uk>, Catalin Marinas <catalin.marinas@....com>, Brian Cain <bcain@...cinc.com>, WANG Xuerui <kernel@...0n.name>, Geert Uytterhoeven <geert@...ux-m68k.org>, Jonas Bonn <jonas@...thpole.se>, Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>, Stafford Horne <shorne@...il.com>, Michael Ellerman <mpe@...erman.id.au>, Naveen N Rao <naveen@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>, Albert Ou <aou@...s.berkeley.edu>, Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, "x86@...nel.org" <x86@...nel.org>, "H . Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>, Bibo Mao <maobibo@...ngson.cn>, Baolin Wang <baolin.wang@...ux.alibaba.com>, "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-csky@...r.kernel.org" <linux-csky@...r.kernel.org>, "linux-hexagon@...r.kernel.org" <linux-hexagon@...r.kernel.org>, "loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>, "linux-m68k@...ts.linux-m68k.org" <linux-m68k@...ts.linux-m68k.org>, "linux-openrisc@...r.kernel.org" <linux-openrisc@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>, Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Qi Zheng <zhengqi.arch@...edance.com>, Vishal Moola <vishal.moola@...il.com>, "Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>, Kemeng Shi <shikemeng@...weicloud.com>, Lance Yang <ioworker0@...il.com>, Peter Xu <peterx@...hat.com>, Barry Song <baohua@...nel.org>, "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org> Cc: Guo Ren <guoren@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, Mike Rapoport <rppt@...nel.org>, Oscar Salvador <osalvador@...e.de>, Alexandre Ghiti <alexghiti@...osinc.com>, Jisheng Zhang <jszhang@...nel.org>, Samuel Holland <samuel.holland@...ive.com>, Anup Patel <anup@...infault.org>, Josh Poimboeuf <jpoimboe@...nel.org>, Breno Leitao <leitao@...ian.org>, Alexander Gordeev <agordeev@...ux.ibm.com>, Gerald Schaefer <gerald.schaefer@...ux.ibm.com>, Hugh Dickins <hughd@...gle.com>, David Hildenbrand <david@...hat.com>, Ryan Roberts <ryan.roberts@....com>, Matthew Wilcox <willy@...radead.org> Subject: Re: [RFC PATCH 00/18] use struct ptdesc to replace pgtable_t On 8/15/24 12:50 AM, LEROY Christophe wrote: > Hi, > > Le 30/07/2024 à 08:46, alexs@...nel.org a écrit : >> From: Alex Shi <alexs@...nel.org> >> >> We have struct ptdesc for page table descriptor a year ago, but it >> has no much usages in kernel, while pgtable_t is used widely. >> >> The pgtable_t is typedefed as 'pte_t *' in sparc, s390, powerpc and m68k >> except SUN3, others archs are all same as 'struct page *'. >> >> These blocks the conception and code update for page table descriptor to >> struct ptdesc. >> >> So, the simple idea to push the ptdesc conception forward is to update >> all pgtable_t by ptdesc or pte_t pointer. But this needs widely >> knowledges for most all of different archs. Common code change is easy >> for include/ and mm/ directory, but it's hard in all archs. >> >> Thanks for intel LKP framework, I fixed most all of build issues except >> a bug on powerpc which reports a "struct ptdesc *" incompatible with >> struct ptdesc *' pointer issue... > > Can you tell more about that problem on powerpc ? Which defconfig for > instance ? > Hi Leroy, Thanks a lot for response. The detailed error and code tree is from LKP: On 8/3/24 11:26 AM, kernel test robot wrote: > tree: https://github.com/alexshi/linux.git ptdesc > head: 3735e634f8feb67c941d17222b53906ace2fd2b8 > commit: 8ac2ea5f299444d065b292043aed0a1e94996159 [14/17] mm/pgtable: use ptdesc in pgtable_trans_huge_deposit > config: powerpc-allyesconfig (https://download.01.org/0day-ci/archive/20240803/202408031130.UnwgnuLS-lkp@intel.com/config) > compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 423aec6573df4424f90555468128e17073ddc69e) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240803/202408031130.UnwgnuLS-lkp@intel.com/reproduce) > In file included from arch/powerpc/include/asm/book3s/64/mmu-hash.h:20: >>> arch/powerpc/include/asm/book3s/64/pgtable.h:1372:52: error: incompatible pointer types passing 'struct ptdesc *' to parameter of type 'struct ptdesc *' [-Werror,-Wincompatible-pointer-types] >> >> Another trouble is pmd_pgtable() conversion in the last patch. >> Maybe some of arch need define theirself own pmd_ptdesc()? >> >> This patchset is immature, even except above 2 issues, I just tested >> virutal machine booting and kselftest mm on x86 and arm64. >> >> Anyway any input are appreciated! > > Can you tell on which tree you based this series ? Last patch doesn't > apply on 6.11-rc1: The code based on akpm/mm-unstable tree, not upstream, you can check the code on: https://github.com/alexshi/linux.git ptdesc Thanks a lot! Alex
Powered by blists - more mailing lists