linux-kernel - [PATCH v2] tools build: Provide consistent build options for fixdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240815072046.1002837-1-agordeev@linux.ibm.com>
Date: Thu, 15 Aug 2024 09:20:46 +0200
From: Alexander Gordeev <agordeev@...ux.ibm.com>
To: Brian Norris <briannorris@...omium.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Cc: linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kbuild@...r.kernel.org, bpf@...r.kernel.org
Subject: [PATCH v2] tools build: Provide consistent build options for fixdep

The fixdep binary is being compiled and linked in one step. While
the host linker flags are passed to the compiler the host compiler
flags are missed.

That leads to build errors at least on x86_64, arm64 and s390 as
result of the compiler vs linker flags inconsistency. For example,
during RPM package build redhat-hardened-ld script is provided to
gcc, while redhat-hardened-cc1 script is missed.

Provide both KBUILD_HOSTCFLAGS and KBUILD_HOSTLDFLAGS to avoid that.

Closes: https://lore.kernel.org/lkml/99ae0d34-ed76-4ca0-a9fd-c337da33c9f9@leemhuis.info/
Fixes: ea974028a049 ("tools build: Avoid circular .fixdep-in.o.cmd issues")
Tested-by: Thorsten Leemhuis <linux@...mhuis.info>
Reviewed-by: Brian Norris <briannorris@...omium.org>
Signed-off-by: Alexander Gordeev <agordeev@...ux.ibm.com>
---

This patch is against kernel-next next-20240815 tag

v2:
- missing tags added
- commit message adjusted

---
 tools/build/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/build/Makefile b/tools/build/Makefile
index fea3cf647f5b..18ad131f6ea7 100644
--- a/tools/build/Makefile
+++ b/tools/build/Makefile
@@ -44,4 +44,4 @@ ifneq ($(wildcard $(TMP_O)),)
 endif
 
 $(OUTPUT)fixdep: $(srctree)/tools/build/fixdep.c
-	$(QUIET_CC)$(HOSTCC) $(KBUILD_HOSTLDFLAGS) -o $@ $<
+	$(QUIET_CC)$(HOSTCC) $(KBUILD_HOSTCFLAGS) $(KBUILD_HOSTLDFLAGS) -o $@ $<
-- 
2.43.0