linux-kernel - Re: [PATCH v2] misc: fastrpc: Fix double free of 'buf' in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a301b77e-b833-482e-afa1-5306bd8fc8e7@stanley.mountain>
Date: Thu, 15 Aug 2024 12:25:04 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: Amol Maheshwari <amahesh@....qualcomm.com>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Abel Vesa <abel.vesa@...aro.org>,
	Sukrut Bellary <sukrut.bellary@...ux.com>,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] misc: fastrpc: Fix double free of 'buf' in error path

On Mon, Jun 12, 2023 at 11:58:01AM +0100, Srinivas Kandagatla wrote:
> 
> On Fri, 02 Jun 2023 04:36:02 -0700, Sukrut Bellary wrote:
> > smatch warning:
> > drivers/misc/fastrpc.c:1926 fastrpc_req_mmap() error: double free of 'buf'
> > 
> > In fastrpc_req_mmap() error path, the fastrpc buffer is freed in
> > fastrpc_req_munmap_impl() if unmap is successful.
> > 
> > But in the end, there is an unconditional call to fastrpc_buf_free().
> > So the above case triggers the double free of fastrpc buf.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] misc: fastrpc: Fix double free of 'buf' in error path
>       commit: 5b3006fffce89706a12741d7f657869ca2be1640
> 

This patch wasn't actually applied.  I'm not sure what went wrong.

regards,
dan carpenter