linux-kernel - Re: [RFC PATCH 6/6] rust: cpufreq: Add rust implementation of cppc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024081519-magenta-giddily-09ad@gregkh>
Date: Thu, 15 Aug 2024 11:24:23 +0200
From: Greg KH <greg@...ah.com>
To: Pierre Gondois <pierre.gondois@....com>
Cc: linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org>,
	Robert Moore <robert.moore@...el.com>,
	Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Wedson Almeida Filho <wedsonaf@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...sung.com>,
	Alice Ryhl <aliceryhl@...gle.com>,
	Martin Rodriguez Reboredo <yakoyoku@...il.com>,
	Manos Pitsidianakis <manos.pitsidianakis@...aro.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	FUJITA Tomonori <fujita.tomonori@...il.com>,
	Thomas Bertschinger <tahbertschinger@...il.com>,
	Danilo Krummrich <dakr@...hat.com>, linux-acpi@...r.kernel.org,
	linux-pm@...r.kernel.org, acpica-devel@...ts.linux.dev,
	rust-for-linux@...r.kernel.org
Subject: Re: [RFC PATCH 6/6] rust: cpufreq: Add rust implementation of
 cppc_cpufreq driver

On Thu, Aug 15, 2024 at 10:29:10AM +0200, Pierre Gondois wrote:
> In an effort to add test/support the cpufreq framework in rust,
> add a rust implementation of the cppc_cpufreq driver named:
> `rcppc_cpufreq`.
> 
> This implementation doesn't support/implement:
> - vendor specific workarounds
> - Frequency Invariance Engine (FIE)
> - artificial Energy Model (EM)
> - (struct cpufreq_driver).attr field
> - QoS requests
> 
> Basic support is provided to get/set the frequency on a platform
> implementing the CPPC section of the ACPI spec.
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@....com>
> ---
>  drivers/cpufreq/Kconfig          |  16 ++
>  drivers/cpufreq/Makefile         |   1 +
>  drivers/cpufreq/rcppc_cpufreq.rs | 333 +++++++++++++++++++++++++++++++
>  3 files changed, 350 insertions(+)
>  create mode 100644 drivers/cpufreq/rcppc_cpufreq.rs

I'm missing why you want to re-implement an existing driver here.  Why
are you going to have 2 drivers for the same functionality/hardware?

How is the system going to handle switching between the two drivers?

thanks,

greg k-h