[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <404a4727-89c6-410b-9ece-301fa399d4db@stanley.mountain>
Date: Thu, 15 Aug 2024 14:24:36 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Rob Herring <robh@...nel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Bart Van Assche <bvanassche@....org>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Brian Masney <bmasney@...hat.com>,
Nitin Rawat <quic_nitirawa@...cinc.com>,
Can Guo <quic_cang@...cinc.com>, linux-scsi@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH] scsi: ufs: ufshcd-pltfrm: Signedness bug in
ufshcd_parse_clock_info()
The "sz" variable needs to be a signed type for the error handling to
work as intended. Fortunately, there is some sanity checking on "sz" on
the next line, so negative values would be caught and it doesn't really
affect runtime.
Fixes: eab0dce11dd9 ("scsi: ufs: ufshcd-pltfrm: Use of_property_count_u32_elems() to get property length")
Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
---
drivers/ufs/host/ufshcd-pltfrm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c
index 0c9b303ccfa0..1f4f30d6cb42 100644
--- a/drivers/ufs/host/ufshcd-pltfrm.c
+++ b/drivers/ufs/host/ufshcd-pltfrm.c
@@ -31,7 +31,7 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba)
const char *name;
u32 *clkfreq = NULL;
struct ufs_clk_info *clki;
- size_t sz = 0;
+ ssize_t sz = 0;
if (!np)
goto out;
--
2.43.0
Powered by blists - more mailing lists