linux-kernel - Re: [EXT] Re: [PATCH v2 40/43] wifi: nxpwifi: add wmm.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v802xb5y.fsf@kernel.org>
Date: Thu, 15 Aug 2024 14:44:57 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: David Lin <yu-hao.lin@....com>,  "linux-wireless@...r.kernel.org"
 <linux-wireless@...r.kernel.org>,  "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>,  "johannes@...solutions.net"
 <johannes@...solutions.net>,  "briannorris@...omium.org"
 <briannorris@...omium.org>,  "francesco@...cini.it"
 <francesco@...cini.it>,  Pete Hsieh <tsung-hsien.hsieh@....com>
Subject: Re: [EXT] Re: [PATCH v2 40/43] wifi: nxpwifi: add wmm.h

Greg KH <gregkh@...uxfoundation.org> writes:

> On Thu, Aug 15, 2024 at 12:43:07PM +0300, Kalle Valo wrote:
>
>> Greg KH <gregkh@...uxfoundation.org> writes:
>> 
>> > On Thu, Aug 15, 2024 at 01:52:18AM +0000, David Lin wrote:
>> >> Hi Greg,
>> >> 
>> >> 	Following the guideline for new driver, it should let every
>> >> file as a single patch for review and generate a final
>> >> 	single patch after reviewing. I think stuffs mentioned by you can be got from cover letter.
>> >> 
>> >> 	If I misunderstood anything, please let me know.
>> >
>> > Please read the kernel documentation for how to submit kernel changes in
>> > a way that we can properly review, and accept them.  As-is, there is
>> > nothing we can do with this series at all, sorry.
>> 
>> Greg, just a bit background for this:
>> 
>> Because wireless drivers can be huge in our documentation we have
>> actually requested to split the driver one patch per file for easier
>> review and avoid mailing list limits:
>> 
>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#new_driver
>> 
>> The final patch to be commited will be just one big patch with a proper
>> commit message.
>
> Ick, wow, good luck!

Wireless drivers can be 40 kLOC and even if you can review a monster
patch like that, us mere mortals cannot :)

> That being said, you still can't take patches without any changelog text
> and most importantly, no signed-off-by lines, right?

I will not accept empty commit messages. I think you misunderstood what
we do so I'll give a concrete example with rtw89 driver. Here's how the
driver was split for review one file per patch:

https://lore.kernel.org/linux-wireless/20201230044223.14085-1-pkshih@realtek.com/

And here's the one big commit the driver was applied to the tree:

https://git.kernel.org/linus/e3ec7017f6a2

Actually initial rtw89 version was a whopping 92 kLOC.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches