linux-kernel - Re: [PATCH v11] ALSA: hda/tas2781: Add tas2781 hda SPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zr3uQ7jdtxqF1FlB@smile.fi.intel.com>
Date: Thu, 15 Aug 2024 15:02:11 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Takashi Iwai <tiwai@...e.de>
Cc: Baojun Xu <baojun.xu@...com>, "Rafael J. Wysocki" <rafael@...nel.org>,
	Hans de Goede <hdegoede@...hat.com>, robh+dt@...nel.org,
	lgirdwood@...il.com, perex@...ex.cz,
	pierre-louis.bossart@...ux.intel.com, kevin-lu@...com,
	shenghao-ding@...com, navada@...com, 13916275206@....com,
	v-hampiholi@...com, v-po@...com, niranjan.hy@...com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	liam.r.girdwood@...el.com, yung-chuan.liao@...ux.intel.com,
	broonie@...nel.org, soyer@....hu
Subject: Re: [PATCH v11] ALSA: hda/tas2781: Add tas2781 hda SPI driver

On Thu, Aug 15, 2024 at 11:08:58AM +0200, Takashi Iwai wrote:
> On Sat, 27 Jul 2024 10:50:48 +0200,
> Baojun Xu wrote:
> > 
> > This patch was used to add TAS2781 devices on SPI support in sound/pci/hda.
> > It use ACPI node descript about parameters of TAS2781 on SPI, it like:
> >     Scope (_SB.PC00.SPI0)
> >     {
> >         Device (GSPK)
> >         {
> >             Name (_HID, "TXNW2781")  // _HID: Hardware ID
> >             Method (_CRS, 0, NotSerialized)
> >             {
> >                 Name (RBUF, ResourceTemplate ()
> >                 {
> >                     SpiSerialBusV2 (...)
> >                     SpiSerialBusV2 (...)
> >                 }
> >             }
> >         }
> >     }
> > 
> > And in platform/x86/serial-multi-instantiate.c, those spi devices will be
> > added into system as a single SPI device, so TAS2781 SPI driver will
> > probe twice for every single SPI device. And driver will also parser
> > mono DSP firmware binary and RCA binary for itself.
> > The code support Realtek as the primary codec.
> > In patch version-10, add multi devices firmware binary support,
> > to compatble with windows driver, they can share same firmware binary.

> Now it's v11, and I'd love to move this forward finally, instead of
> hanging forever.
> 
> The HD-audio part looks more or less OK, but I'd need acks for the
> ACPI and serial-multi-instance parts below.
> 
> Put ACPI and serial-multi-instance maintainers to Cc.
> Rafael, Hans, let me know if that looks OK to take.

FWIW, the ACPI ID part is legit, if the requirement to include it to those
tables, it looks good.

-- 
With Best Regards,
Andy Shevchenko