linux-kernel - Re: [PATCH v2 6/6] arm64: dts: ti: k3-am65: Add ESM nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240815123219.ovn7hdvnhseh37bb@multiple>
Date: Thu, 15 Aug 2024 07:32:19 -0500
From: Nishanth Menon <nm@...com>
To: Judith Mendez <jm@...com>
CC: Jan Kiszka <jan.kiszka@...mens.com>, <devicetree@...r.kernel.org>,
        Vignesh
 Raghavendra <vigneshr@...com>, <linux-kernel@...r.kernel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Rob Herring
	<robh@...nel.org>
Subject: Re: [PATCH v2 6/6] arm64: dts: ti: k3-am65: Add ESM nodes

On 09:05-20240814, Judith Mendez wrote:
> Hi all,
> 
> On 8/13/24 6:03 PM, Judith Mendez wrote:
> > Add Error Signaling Module (ESM) instances in MCU and MAIN
> > domains, set ESM interrupt sources for rti as per TRM [0] 9.4
> > Interrupt Sources.
> > 
> > Add comments to describe what interrupt sources are routed to
> > ESM modules.
> > 
> > [0] https://www.ti.com/lit/ug/spruid7e/spruid7e.pdf

As mentioned[1], please update the commit message

> > 
> > Signed-off-by: Judith Mendez <jm@...com>
> > ---
> > Changes since v1:
> > - Add patch 6/6 for am65x
> > ---
> >   arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 8 ++++++++
> >   arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi  | 8 ++++++++
> >   2 files changed, 16 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > index 1af3dedde1f67..07c9f043dac0b 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > @@ -54,6 +54,14 @@ gic_its: msi-controller@...0000 {
> >   		};
> >   	};
> > +	main_esm: esm@...000 {
> > +		compatible = "ti,j721e-esm";
> > +		reg = <0x00 0x700000 0x00 0x1000>;
> > +		/* Interrupt sources: rti0, rti1, rti2, rti3 */
> > +		ti,esm-pins = <224>, <225>, <226>, <227>;
> 
> I am not sure if someone knows the answer to this question, but..
> 
> I noticed that for rti, the interrupt source id's are different
> for SR1 vs SR2, so which should be used here in k3-am65-main?
> 
> Here, I assumed SR2.

The only production board with SR1.0 that I am aware of is
arch/arm64/boot/dts/ti/k3-am65-iot2050-common-pg1.dtsi I think - Jan can
clarify. The technique used is to do an override in the dtsi if I am not
mistaken.

[1] https://lore.kernel.org/all/20240815122928.4i2yob5aj5ssqhzw@reply/
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D