linux-kernel - RE: [PATCH] iommu/arm-smmu-v3: Fix a NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc6b31a1cb334ecf8458e888d66e362a@huawei.com>
Date: Thu, 15 Aug 2024 13:03:50 +0000
From: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@...wei.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>, "Joerg
 Roedel" <joro@...tes.org>, Jason Gunthorpe <jgg@...pe.ca>, Nicolin Chen
	<nicolinc@...dia.com>, Michael Shavit <mshavit@...gle.com>, Mostafa Saleh
	<smostafa@...gle.com>, Lu Baolu <baolu.lu@...ux.intel.com>, Kevin Tian
	<kevin.tian@...el.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "iommu@...ts.linux.dev"
	<iommu@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] iommu/arm-smmu-v3: Fix a NULL vs IS_ERR() check



> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@...aro.org>
> Sent: Thursday, August 15, 2024 12:25 PM
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@...wei.com>
> Cc: Will Deacon <will@...nel.org>; Robin Murphy
> <robin.murphy@....com>; Joerg Roedel <joro@...tes.org>; Jason
> Gunthorpe <jgg@...pe.ca>; Nicolin Chen <nicolinc@...dia.com>; Michael
> Shavit <mshavit@...gle.com>; Mostafa Saleh <smostafa@...gle.com>; Lu
> Baolu <baolu.lu@...ux.intel.com>; Kevin Tian <kevin.tian@...el.com>; linux-
> arm-kernel@...ts.infradead.org; iommu@...ts.linux.dev; linux-
> kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
> Subject: [PATCH] iommu/arm-smmu-v3: Fix a NULL vs IS_ERR() check
> 
> The arm_smmu_domain_alloc() function returns error pointers on error.  It
> doesn't return NULL.  Update the error checking to match.
> 
> Fixes: 52acd7d8a413 ("iommu/arm-smmu-v3: Add support for
> domain_alloc_user fn")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>

Thanks,
Shameer