linux-kernel - Re: [PATCH 2/4] Documentation: dwc_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a6bf90e-ce7f-8a20-93a1-63a75f312392@huawei.com>
Date: Thu, 15 Aug 2024 21:44:32 +0800
From: Yicong Yang <yangyicong@...wei.com>
To: Krishna chaitanya chundru <quic_krichai@...cinc.com>
CC: Shuai Xue <xueshuai@...ux.alibaba.com>, Jing Zhang
	<renyu.zj@...ux.alibaba.com>, Will Deacon <will@...nel.org>, Mark Rutland
	<mark.rutland@....com>, Baolin Wang <baolin.wang@...ux.alibaba.com>, Yicong
 Yang <yangyicong@...ilicon.com>, Jonathan Cameron
	<Jonathan.Cameron@...wei.com>, Jonathan Corbet <corbet@....net>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-arm-msm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<quic_vbadigan@...cinc.com>, <quic_nitegupt@...cinc.com>,
	<quic_skananth@...cinc.com>, <quic_ramkri@...cinc.com>,
	<quic_parass@...cinc.com>, <quic_mrana@...cinc.com>
Subject: Re: [PATCH 2/4] Documentation: dwc_pcie_pmu: Update bdf to sbdf

On 2024/7/31 12:23, Krishna chaitanya chundru wrote:
> Update document to reflect the driver change to use sbdf instead
> of bdf alone.
> 
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@...cinc.com>

Reviewed-by: Yicong Yang <yangyicong@...ilicon.com>

> ---
>  Documentation/admin-guide/perf/dwc_pcie_pmu.rst | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/admin-guide/perf/dwc_pcie_pmu.rst b/Documentation/admin-guide/perf/dwc_pcie_pmu.rst
> index d47cd229d710..39b8e1fdd0cd 100644
> --- a/Documentation/admin-guide/perf/dwc_pcie_pmu.rst
> +++ b/Documentation/admin-guide/perf/dwc_pcie_pmu.rst
> @@ -46,16 +46,16 @@ Some of the events only exist for specific configurations.
>  DesignWare Cores (DWC) PCIe PMU Driver
>  =======================================
>  
> -This driver adds PMU devices for each PCIe Root Port named based on the BDF of
> +This driver adds PMU devices for each PCIe Root Port named based on the SBDF of
>  the Root Port. For example,
>  
> -    30:03.0 PCI bridge: Device 1ded:8000 (rev 01)
> +    0001:30:03.0 PCI bridge: Device 1ded:8000 (rev 01)
>  
> -the PMU device name for this Root Port is dwc_rootport_3018.
> +the PMU device name for this Root Port is dwc_rootport_13018.
>  
>  The DWC PCIe PMU driver registers a perf PMU driver, which provides
>  description of available events and configuration options in sysfs, see
> -/sys/bus/event_source/devices/dwc_rootport_{bdf}.
> +/sys/bus/event_source/devices/dwc_rootport_{sbdf}.
>  
>  The "format" directory describes format of the config fields of the
>  perf_event_attr structure. The "events" directory provides configuration
> @@ -66,16 +66,16 @@ The "perf list" command shall list the available events from sysfs, e.g.::
>  
>      $# perf list | grep dwc_rootport
>      <...>
> -    dwc_rootport_3018/Rx_PCIe_TLP_Data_Payload/        [Kernel PMU event]
> +    dwc_rootport_13018/Rx_PCIe_TLP_Data_Payload/        [Kernel PMU event]
>      <...>
> -    dwc_rootport_3018/rx_memory_read,lane=?/               [Kernel PMU event]
> +    dwc_rootport_13018/rx_memory_read,lane=?/               [Kernel PMU event]
>  
>  Time Based Analysis Event Usage
>  -------------------------------
>  
>  Example usage of counting PCIe RX TLP data payload (Units of bytes)::
>  
> -    $# perf stat -a -e dwc_rootport_3018/Rx_PCIe_TLP_Data_Payload/
> +    $# perf stat -a -e dwc_rootport_13018/Rx_PCIe_TLP_Data_Payload/
>  
>  The average RX/TX bandwidth can be calculated using the following formula:
>  
> @@ -88,7 +88,7 @@ Lane Event Usage
>  Each lane has the same event set and to avoid generating a list of hundreds
>  of events, the user need to specify the lane ID explicitly, e.g.::
>  
> -    $# perf stat -a -e dwc_rootport_3018/rx_memory_read,lane=4/
> +    $# perf stat -a -e dwc_rootport_13018/rx_memory_read,lane=4/
>  
>  The driver does not support sampling, therefore "perf record" will not
>  work. Per-task (without "-a") perf sessions are not supported.
>