linux-kernel - Re: [PATCH] dt-bindings: power: supply: sc27xx-fg: add low voltage alarm IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240815-winnings-waving-1ec5561f90e7@spud>
Date: Thu, 15 Aug 2024 15:46:18 +0100
From: Conor Dooley <conor@...nel.org>
To: Stanislav Jakubek <stano.jakubek@...il.com>
Cc: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Orson Zhai <orsonzhai@...il.com>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@...il.com>, linux-pm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: power: supply: sc27xx-fg: add low voltage
 alarm IRQ

On Thu, Aug 15, 2024 at 12:01:36PM +0200, Stanislav Jakubek wrote:
> The SC27XX fuel gauge supports a low voltage alarm IRQ, which is used
> for more accurate battery capacity measurements with lower voltages.
> 
> This was unfortunately never documented in bindings, do so now.
> 
> Signed-off-by: Stanislav Jakubek <stano.jakubek@...il.com>
> ---
> Initial Linux driver submission adding this feature:
> https://lore.kernel.org/lkml/ee1dd39f126bd03fb88381de9663d32df994d341.1542185618.git.baolin.wang@linaro.org/
> 
> The only in-tree user (sc2731.dtsi) has had interrupts specified since its
> initial fuel-gauge submission:
> https://lore.kernel.org/lkml/4f66af3b47ba241380f8092e08879aca6d7c35b3.1548052878.git.baolin.wang@linaro.org/

This context could go into the commit message I think, as justification
for making the interrupt required.

Also, this binding is odd in that it has several compatibles in an enum,
but the driver (added at the same time) only has one compatible in it.
Are you using the sc2731 in your device?

> 
>  .../devicetree/bindings/power/supply/sc27xx-fg.yaml         | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/sc27xx-fg.yaml b/Documentation/devicetree/bindings/power/supply/sc27xx-fg.yaml
> index de43e45a43b7..9108a2841caf 100644
> --- a/Documentation/devicetree/bindings/power/supply/sc27xx-fg.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/sc27xx-fg.yaml
> @@ -27,6 +27,9 @@ properties:
>    battery-detect-gpios:
>      maxItems: 1
>  
> +  interrupts:
> +    maxItems: 1
> +
>    io-channels:
>      items:
>        - description: Battery Temperature ADC
> @@ -53,6 +56,7 @@ required:
>    - compatible
>    - reg
>    - battery-detect-gpios
> +  - interrupts
>    - io-channels
>    - io-channel-names
>    - nvmem-cells
> @@ -88,6 +92,8 @@ examples:
>          compatible = "sprd,sc2731-fgu";
>          reg = <0xa00>;
>          battery-detect-gpios = <&pmic_eic 9 GPIO_ACTIVE_HIGH>;
> +        interrupt-parent = <&sc2731_pmic>;
> +        interrupts = <4>;
>          io-channels = <&pmic_adc 5>, <&pmic_adc 14>;
>          io-channel-names = "bat-temp", "charge-vol";
>          nvmem-cells = <&fgu_calib>;
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)