linux-kernel - Re: [PATCH net-next 4/4] net: xilinx: axienet: Support IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240815150218.GJ632411@kernel.org>
Date: Thu, 15 Aug 2024 16:02:18 +0100
From: Simon Horman <horms@...nel.org>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Lunn <andrew@...n.ch>, Michal Simek <michal.simek@....com>,
	Daniel Borkmann <daniel@...earbox.net>,
	Paolo Abeni <pabeni@...hat.com>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	linux-arm-kernel@...ts.infradead.org,
	Jakub Kicinski <kuba@...nel.org>,
	Ariane Keller <ariane.keller@....ee.ethz.ch>
Subject: Re: [PATCH net-next 4/4] net: xilinx: axienet: Support IFF_ALLMULTI

On Mon, Aug 12, 2024 at 04:04:37PM -0400, Sean Anderson wrote:
> Add support for IFF_ALLMULTI by configuring a single filter to match the
> multicast address bit. This allows us to keep promiscuous mode disabled,
> even when we have more than four multicast addresses. An even better
> solution would be to "pack" addresses into the available CAM registers,
> but that can wait for a future series.
> 
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>

My comment on patch 1/4 notwithstanding, this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>