[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240815-illusive-pusher-43d3cced8bc9@spud>
Date: Thu, 15 Aug 2024 16:05:29 +0100
From: Conor Dooley <conor@...nel.org>
To: Detlev Casanova <detlev.casanova@...labora.com>
Cc: linux-kernel@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Heiko Stuebner <heiko@...ech.de>, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: Add rk3576 pinctrl bindings
On Wed, Aug 14, 2024 at 06:30:38PM -0400, Detlev Casanova wrote:
> Add the compatible string as well as the rockchip,sys-grf field which is
> only used on this SoC.
>
> Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> .../bindings/pinctrl/rockchip,pinctrl.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> index 20e806dce1ecb..28f8dc412cf92 100644
> --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> @@ -45,6 +45,7 @@ properties:
> - rockchip,rk3368-pinctrl
> - rockchip,rk3399-pinctrl
> - rockchip,rk3568-pinctrl
> + - rockchip,rk3576-pinctrl
> - rockchip,rk3588-pinctrl
> - rockchip,rv1108-pinctrl
> - rockchip,rv1126-pinctrl
> @@ -62,6 +63,12 @@ properties:
> Required for at least rk3188 and rk3288. On the rk3368 this should
> point to the PMUGRF syscon.
>
> + rockchip,sys-grf:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + The phandle of the syscon node for the SYS GRF registers.
> + It is used on rk3576 for i3c software controlled weak pull-up.
> +
> "#address-cells":
> enum: [1, 2]
>
> @@ -72,6 +79,17 @@ properties:
>
> allOf:
> - $ref: pinctrl.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: rockchip,rk3576-pinctrl
> + then:
> + required:
> + - rockchip,sys-grf
> + else:
> + properties:
> + rockchip,sys-grf: false
>
> required:
> - compatible
> --
> 2.46.0
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists