linux-kernel - Re: [RFC PATCH 01/11] dt-bindings: mailbox: mpfs: fix reg properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172373604837.1948390.3086850523957574490.robh@kernel.org>
Date: Thu, 15 Aug 2024 09:34:10 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Lee Jones <lee@...nel.org>, 
 Conor Dooley <conor.dooley@...rochip.com>, linux-kernel@...r.kernel.org, 
 devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [RFC PATCH 01/11] dt-bindings: mailbox: mpfs: fix reg
 properties


On Thu, 15 Aug 2024 15:01:03 +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> When the binding for this was originally written, and later modified,
> mistakes were made - and the precise nature of the later modification
> should have been a giveaway, but alas I was naive at the time.
> 
> A more correct modelling of the hardware is to use two syscons and have
> a single reg entry for the mailbox, containing the mailbox region. The
> two syscons contain the general control/status registers for the mailbox
> and the interrupt related registers respectively. The reason for two
> syscons is that the same mailbox is present on the non-SoC version of
> the FPGA, which has no interrupt controller, and the shared part of the
> rtl was unchanged between devices.
> 
> This is now coming to a head, because the control/status registers share
> a register region with the "tvs" (temperature & voltage sensors)
> registers and, as it turns out, people do want to monitor temperatures
> and voltages...
> 
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
>  .../bindings/mailbox/microchip,mpfs-mailbox.yaml       | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.example.dts:27.13-38: Warning (reg_format): /example-0/soc/mailbox@...20800:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.example.dts:25.28-31.13: Warning (avoid_default_addr_size): /example-0/soc/mailbox@...20800: Relying on default #address-cells value
Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.example.dts:25.28-31.13: Warning (avoid_default_addr_size): /example-0/soc/mailbox@...20800: Relying on default #size-cells value
Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.example.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size'

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240815-premiere-given-1dab82e67eba@spud

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.